Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): filter on collections not working #249

Conversation

pheuberger
Copy link
Member

Without this patch filtering doesn't work on collections. The following query returns all collections instead of the one that's filtered for:

{
  collections(where: { name: { eq: "test"}}) {
    data {
      name
      id
      hypercerts {
        hypercert_id
      }
    }
  }
}

The same holds true for ids.

Without this patch filtering doesn't work on collections. The following
query returns all collections instead of the one that's filtered for:

{
  collections(where: { name: { eq: "test"}}) {
    data {
      name
      id
      hypercerts {
        hypercert_id
      }
    }
  }
}

The same holds true for ids.
Tests would complain when the Alchemy env var isn't found. The tests
shouldn't even need it. This most likely came to be when the RPC URL
building was changed and this test was missed.
The new mocks catch that oversight.
Adding code inside of baseTypes.ts requires us to lower the coverage
thresholds as it's notoriously difficult to test.
@pheuberger pheuberger force-pushed the fix-collections-graphql-filtering branch from 2f0b670 to 6af04d5 Compare February 7, 2025 19:09
@bitbeckers bitbeckers added the bug Something isn't working label Feb 9, 2025
@bitbeckers bitbeckers merged commit eba09e0 into hypercerts-org:develop Feb 9, 2025
1 check passed
@pheuberger pheuberger deleted the fix-collections-graphql-filtering branch February 10, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Filtering on collections entity doesn't work [Test] Test should not need alchemy api key
2 participants